impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Date Mon, 07 Aug 2017 19:26:08 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
......................................................................


Patch Set 3:

(3 comments)

LGTM. Please address the question in ~MemTracker().

http://gerrit.cloudera.org:8080/#/c/7492/3/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:

PS3, Line 114:  if (consumption_metric_ == nullptr) {
Why this change ? Why not always have the DCHECK() below ?


PS3, Line 200: Close(); // Various backend tests do not call Close(). Clean up for them.
Ideally, we'd like to have a DCHECK(closed_) here if we fix up all backend tests.


http://gerrit.cloudera.org:8080/#/c/7492/3/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

Line 80:     // No more tracked memory should be used by the query after this point, so we
can close
nit: long line


-- 
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message