impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo
Date Mon, 07 Aug 2017 00:33:17 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4407: Move Impala setup procedures to main repo
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7587/2/bin/bootstrap_development.sh
File bin/bootstrap_development.sh:

Line 22: # configurations, so it is best to run this in a fresh install. It also sets up the
> Done
I was more thinking of "what if the script fails after step X?" - is it possible to restart
it and it will continue from there? Some of it's actions are not idempotent so I suspect that
it's not possible, which means once something goes wrong, a user has to finish the steps manually.
I think that's fine, but we should mention it. My apologies that I wasn't more clear.


Line 30: # metadata without using a snapshot (which takes about 2 hours) and it then runs
the full
> Since Jenkins jobs are configured away from this script, I'd prefer to keep
Yes, good point.


PS2, Line 34: , you can run
> I'm OK with it printing. For a batch bash script, and one that runs the tes
I don't feel strongly about either. "set -x" will make it print all of the steps, too.


-- 
To view, visit http://gerrit.cloudera.org:8080/7587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728abfa806ecd9461dfb443278c2a464714d984c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message