impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface
Date Fri, 04 Aug 2017 22:46:01 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface
......................................................................


Patch Set 7:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/7542/7/be/src/runtime/data-stream-mgr-base.h
File be/src/runtime/data-stream-mgr-base.h:

PS7, Line 36: Thrfit and KRPC
            : /// respectively. Remove this when we evenually get rid of the Thrift implementation
and
            : /// replace client references to this class with the KRPC's version of the
            : /// DataStreamMgrBase.
> same comments and typos as elsewhere.
Done


http://gerrit.cloudera.org:8080/#/c/7542/7/be/src/runtime/data-stream-mgr.h
File be/src/runtime/data-stream-mgr.h:

PS7, Line 22: #include "runtime/data-stream-mgr-base.h"
> Move to line 33, with the other Impala includes.
Done


http://gerrit.cloudera.org:8080/#/c/7542/7/be/src/runtime/data-stream-recvr-base.h
File be/src/runtime/data-stream-recvr-base.h:

PS7, Line 33: Thrfit
> typo
Done


PS7, Line 34: respectively
> remove (there's nothing in this sentence for them to be respective to).
Done


PS7, Line 34: when we evenually get rid of the Thrift implementation and
            : /// replace client references to this class with the KRPC's version of the
            : /// DataStreamRecvrBase.
> "in favor of the KRPC implementation when possible".
Done


http://gerrit.cloudera.org:8080/#/c/7542/7/be/src/runtime/data-stream-recvr.h
File be/src/runtime/data-stream-recvr.h:

PS7, Line 42: /// Single receiver of an m:n data stream.
> This should say something about the fact that it's the thrift implementatio
Done


http://gerrit.cloudera.org:8080/#/c/7542/7/be/src/runtime/data-stream-test.cc
File be/src/runtime/data-stream-test.cc:

PS7, Line 460: ImpalaTestBackend
> Is it hard to convert ImpalaTestBackend to accept a DataStreamMgrBase ?
That would mean I have to do the dynamic cast of the 'mgr_' object in L100 from DataStreamMgrBase
to DataStreamMgr, which I thought was a little more ugly than this test client class explicitly
using a DataStreamMgr.


http://gerrit.cloudera.org:8080/#/c/7542/7/be/src/runtime/exec-env.h
File be/src/runtime/exec-env.h:

PS7, Line 93: enforced by
> 'part of' ?
Done


PS7, Line 94: (This is due to the stream mgrs using different AddData() signatures)
> Would remove this.
Done


http://gerrit.cloudera.org:8080/#/c/7542/7/be/src/runtime/krpc-data-stream-recvr.cc
File be/src/runtime/krpc-data-stream-recvr.cc:

Line 52: }
> return Status::OK()? Otherwise clang-tidy might complain. Here and elsewher
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message