impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface
Date Fri, 04 Aug 2017 22:45:44 GMT
Sailesh Mukil has uploaded a new patch set (#8).

Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface

IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface

This patch introduces a dummy 'use_krpc' flag and creates an abstract
interface for the DataStreamRecvr/Mgr.

The 'use_krpc' flag defaults to 'false'. Cluster startup will abort
with an error if the flag is switched to 'true'.

The DataStreamSender implements the same virtual interface as the
DataSink, so a pure virtual class for the DataStreamSender would
essentially be an empty class. Therefore, it is not implemented.

The new interfaces are pure virtual base classes and are named

Stubs for the Krpc implementations are also introduced and are named
KrpcDataStream*. They currently only abort with a fatal error if they
are used. Their actual implementations will be filled in a later

Since having both the Thrift and KRPC implementations of the
DataStream* classes are only expected to be temporary for now, this
was written and optimized with the end goal of having only the KRPC
versions of the DataStreamMgr/Recvr, at which point we will get rid
of the DataStream*Base classes, the Thrift versions of the classes
and rename KrpcDataStream* to DataStream*. We will also rename all
the references that the clients have to DataStream*Base to DataStream*.

Also did some spurious includes cleanup.

Change-Id: I5d52245154e910529a68f53049520238eca16241
M be/src/exec/
M be/src/exec/
M be/src/exec/exchange-node.h
M be/src/runtime/CMakeLists.txt
A be/src/runtime/data-stream-mgr-base.h
M be/src/runtime/
M be/src/runtime/data-stream-mgr.h
A be/src/runtime/data-stream-recvr-base.h
M be/src/runtime/data-stream-recvr.h
M be/src/runtime/
M be/src/runtime/
M be/src/runtime/exec-env.h
M be/src/runtime/
A be/src/runtime/
A be/src/runtime/krpc-data-stream-mgr.h
A be/src/runtime/
A be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/
M be/src/runtime/runtime-state.h
M be/src/service/
20 files changed, 442 insertions(+), 39 deletions(-)

  git pull ssh:// refs/changes/42/7542/8
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>

View raw message