impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner
Date Fri, 04 Aug 2017 21:11:38 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5572: Timestamp codegen for text scanner
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7556/3/be/src/exec/text-converter.cc
File be/src/exec/text-converter.cc:

Line 269:     if (parse_fn->arg_size() == 3) builder.CreateStore(parse_return, slot);
There was a warning from clang-tidy:
  20:19:26 ] /home/ubuntu/Impala/be/src/exec/text-converter.cc:269:56: warning: variable 'parse_return'
may be uninitialized when used here [clang-diagnostic-conditional-uninitialized]

It's not actually possible, but we could initialise parse_return to nullptr to avoid it.


-- 
To view, visit http://gerrit.cloudera.org:8080/7556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message