impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Problem: Improve error message when subquery is used in the ON clause
Date Fri, 04 Aug 2017 19:03:19 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: Problem: Improve error message when subquery is used in the ON clause
......................................................................


Patch Set 1:

(2 comments)

The fix looks Ok. Couple of nits in the commit message. Additionally,

- Can you please add a unit test in AnalyzeStmtsTest#TestOnClause()? Generally unit tests
are expected for every commit, unless it is pretty difficult to reproduce.

- Please update your gerrit profile to include your name, else it shows up as "Anonymous Coward"
in email updates.

http://gerrit.cloudera.org:8080/#/c/7588/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Problem
Could you replace it with the jira ID?  Typically we include jira ID in the messages to make
git log searchable.  Something like,

IMPALA-xxxx:  Improve error message when subquery is used in the ON clause


PS1, Line 10: Fix: Print the error stating that "Suquery not allowed in the ON clause"
Move above the change-Id.


-- 
To view, visit http://gerrit.cloudera.org:8080/7588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1dc47987de7ea04402e1ead31d81cddf2f96f2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message