impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end
Date Fri, 04 Aug 2017 18:31:18 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-1575: Yield admission control resources at query end
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7079/3/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 1086: void Coordinator::ReleaseResources() {
I'm having trouble understanding whether this runs before or after QueryState::ReleaseResources().
It seems like we to release memory tracked by filter_mem_tracker_ before QueryState::ReleaseResources(),
but then we need to release the admission control resources after QueryState::ReleaseResources()
is called.

There's a good chance I'm misunderstanding something but that's what I'm stuck on right now.


-- 
To view, visit http://gerrit.cloudera.org:8080/7079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcelk@gmail.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message