impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components
Date Fri, 04 Aug 2017 16:12:31 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5764: Allow overriding packaged components

Patch Set 1:

Commit Message:

Line 9: For allowing multiple different distributions to build against the same
Maybe briefly mention the relevant environment variables so it's more discoverable to people
looking at the commit message only.
File bin/

Line 39: HOST = ""
It might make sense to also allow configuring this URL, so it can be pointed to an alternative
source of the components.
File bin/

PS1, Line 131: cdh
> is it too painful to change this string? i guess renaming would break exist
Keeping it as cdh_components kind-of makes sense to me as long as we're putting CDH components
in there, to allow parallel sets of components (e.g. apache_components).

Or I guess maybe it could also make sense to have hadoop_components/ minicluster_components
or something like that with everything under it, distinguished by version numbers.

I don't feel strongly either way.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I95c2662e6f62adc924cc5de7a371202126046545
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message