impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Date Fri, 04 Aug 2017 00:47:26 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

Looks good to me. Lets see if Michael wants to take another look.

http://gerrit.cloudera.org:8080/#/c/7492/2/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:

PS2, Line 200: Various backend tests do not 
> Lots of backend tests rely on the destructor cleaning these up. It's a pret
Ah right, thanks.


http://gerrit.cloudera.org:8080/#/c/7492/2/be/src/runtime/mem-tracker.h
File be/src/runtime/mem-tracker.h:

PS2, Line 105:   /// Closes the MemTracker and deregisters it from its parent. Can be called
before
             :   /// destruction to prevent other threads from getting a reference to the
MemTracker
             :   /// via its par
> I'm not sure if I understood the exact suggestion. I combined this with Clo
Yup works for me, thanks


http://gerrit.cloudera.org:8080/#/c/7492/2/be/src/runtime/runtime-state.cc
File be/src/runtime/runtime-state.cc:

Line 260: void RuntimeState::ReleaseResources() {
> I think it's mostly depended on what was simpler in context - in a lot of p
Yeah, makes sense. I think it'd be easier to reason about if it were consistent but that's
not really something that would need to be addressed now.


-- 
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message