impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5757: Order-dependent comparison fails in test kudu
Date Thu, 03 Aug 2017 22:33:09 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu

Patch Set 1:

> > > (1 comment)
 > >
 > > I recently changed several places in the FE to use LinkedHashMaps
 > > in order to get deterministic ordering. That included
 > >, so I'm surprised the order is not
 > > deterministic. I suspect that file has the code that needs
 > fixing,
 > > possibly L427 propertyMapToSql(). Maybe it'd be best to sort the
 > > properties to be completely independent from the underlying
 > > storage.
 > Yup, that looks correct. I think we can just create a LinkedHashSet
 > from the entrySet(). Hopefully that won't break too many existing
 > tests.

At that poing propertyMap is already a LinkedHashMap, so I think the order of the entrySet
should be stable (see

I think msTable.getParameters() returns a Map<>, which means we may have to sort it
to get a deterministic order.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I64ce0c49fcbab3a4810d52c131bc176f8567ff9e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: No

View raw message