impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5757: Order-dependent comparison fails in test kudu
Date Thu, 03 Aug 2017 20:37:30 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5757: Order-dependent comparison fails in test_kudu
......................................................................


Patch Set 1:

> (1 comment)

I recently changed several places in the FE to use LinkedHashMaps in order to get deterministic
ordering. That included ToSqlUtils.java:212, so I'm surprised the order is not deterministic.
I suspect that file has the code that needs fixing, possibly L427 propertyMapToSql(). Maybe
it'd be best to sort the properties to be completely independent from the underlying storage.

-- 
To view, visit http://gerrit.cloudera.org:8080/7575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64ce0c49fcbab3a4810d52c131bc176f8567ff9e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message