impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5756: start memory maintenance thread after metric creation
Date Thu, 03 Aug 2017 05:31:19 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5756: start memory maintenance thread after metric creation
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7573/1/be/src/common/init.cc
File be/src/common/init.cc:

Line 250:   memory_maintenance_thread.reset(
What happened to the is_test() logic?


Line 251:       new Thread("common", "memory-maintenance-thread", &MemoryMaintenanceThread));
is there some DCHECK we can put on line 250? (something like AggregateMetrics::NUM_SMAPS !=
nullptr?)


http://gerrit.cloudera.org:8080/#/c/7573/1/be/src/service/impalad-main.cc
File be/src/service/impalad-main.cc:

Line 93:   Status status = exec_env.StartServices();
Isn't this where RegisterMemoryMetrics() is called?


-- 
To view, visit http://gerrit.cloudera.org:8080/7573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb7337a68547b4d660f3100b04df2c20befb044c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: Yes

Mime
View raw message