impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5602: Fix kudu queries being incorrectly optimized as small query
Date Wed, 02 Aug 2017 23:36:22 GMT
Bikramjeet Vig has posted comments on this change.

Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query
......................................................................


Patch Set 2:

> Do you have a test for the case when the table is missing stats? I
 > think there may be a similar bug in MaxRowsProcessedVisitor for
 > that case:
 > 
 > 
 > if (scan.isAccessingCollectionType()
 > || (missingStats && !(scan.hasLimit() && scan.getConjuncts().isEmpty())))
 > {

Good catch! fixed this in the latest patch as well
Thanks

-- 
To view, visit http://gerrit.cloudera.org:8080/7560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message