impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface
Date Wed, 02 Aug 2017 23:03:15 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface
......................................................................


Patch Set 5:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/7542/5/be/src/exec/exchange-node.cc
File be/src/exec/exchange-node.cc:

PS5, Line 80: // TODO: Remove DCHECK when KRPC is supported.
            :   DCHECK(!FLAGS_use_krpc);
won't this get triggered during CreateImpalaServer() anyhow? Not sure whether it's worth repeating
this check.


http://gerrit.cloudera.org:8080/#/c/7542/5/be/src/runtime/data-stream-mgr-base.h
File be/src/runtime/data-stream-mgr-base.h:

PS5, Line 29: MetricGroup
not needed?


http://gerrit.cloudera.org:8080/#/c/7542/5/be/src/runtime/data-stream-mgr.h
File be/src/runtime/data-stream-mgr.h:

Line 71:   virtual ~DataStreamMgr();
override?


http://gerrit.cloudera.org:8080/#/c/7542/5/be/src/runtime/data-stream-recvr-base.h
File be/src/runtime/data-stream-recvr-base.h:

PS5, Line 22: #include "util/tuple-row-compare.h"
needed?


http://gerrit.cloudera.org:8080/#/c/7542/5/be/src/runtime/data-stream-recvr.h
File be/src/runtime/data-stream-recvr.h:

Line 67:   virtual ~DataStreamRecvr();
override


http://gerrit.cloudera.org:8080/#/c/7542/5/be/src/runtime/data-stream-test.cc
File be/src/runtime/data-stream-test.cc:

Line 611:   shared_ptr<DataStreamRecvrBase> stream_recvr = stream_mgr_->CreateRecvr(runtime_state.get(),
long line


http://gerrit.cloudera.org:8080/#/c/7542/5/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

Line 78: DEFINE_bool(use_krpc, false, "Used to indicate whether to use KRPC for the DataStream
"
make this DEFINE_bool_hidden until KRPC goes in.


-- 
To view, visit http://gerrit.cloudera.org:8080/7542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message