impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten
Date Wed, 02 Aug 2017 21:50:03 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7567/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java
File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java:

PS1, Line 57: 
> nit: can you put this in a separate sentence on the next line, e.g.
Done


PS1, Line 58: a
            :   // NULL value if the entire tuple is NULL, for example as 
> nit: '..., for example as the result of an outer join.'
Done


http://gerrit.cloudera.org:8080/#/c/7567/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java:

PS1, Line 103:    * Simplify COALESCE by skipping leading nulls and applying the following
transformations:
             :    * COALESCE(null, a, b) -> COALESCE(a, b);
             :    * COALESCE(<literal>, a, b) -> <literal>, when literal is
not NullLiteral;
             :    */
             :   private Expr simplifyCoalesceFunctionCallExpr(Funct
> update
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca6df949f9d416ab207016236dbcb5886295337
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message