impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3200: more buffer pool end-to-end tests
Date Wed, 02 Aug 2017 19:52:57 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3200: more buffer pool end-to-end tests
......................................................................


Patch Set 5:

(2 comments)

Oops, clarified the inline exhaustive / skip risk with a clearer comment. Sorry.

http://gerrit.cloudera.org:8080/#/c/7552/5/tests/query_test/test_mem_usage_scaling.py
File tests/query_test/test_mem_usage_scaling.py:

PS5, Line 92:     return 'tpch'
> Workload will not run under exhaustive.
Clarification: If someone later attempts to skip these tests except when in exhaustive, the
tests under this workload will never run.


PS5, Line 254:     return 'targeted-perf'
> Workload will not run under exhaustive.
Clarification: If someone later attempts to skip these tests except when in exhaustive, the
tests under this workload will never run.


-- 
To view, visit http://gerrit.cloudera.org:8080/7552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I554aa5ddfef4f8e75295596e720a14eee1afa17f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message