impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE
Date Wed, 02 Aug 2017 19:39:50 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE

Patch Set 1:

File fe/src/main/java/org/apache/impala/planner/

PS1, Line 119: // compute filters

PS1, Line 121: ctx_.getAnalysisResult().getTimeline().markEvent(
             :           "Runtime filters computed");
single line?
File fe/src/main/java/org/apache/impala/planner/

Line 538:    * The assigned filters are the ones for which 'scanNode' can be used a destination
update this comment

PS1, Line 549: TRuntimeFilterMode runtimeFilterMode =
             :         ctx.getQueryOptions().getRuntime_filter_mode();
single line?

PS1, Line 590: :
nit: space before ':'
File testdata/workloads/functional-query/queries/QueryTest/runtime_filters_distrib_pruning.test:

Line 1: ====
I suppose these are written as query tests and not planner tests because the planner tests
don't have a good way to 'SET' on a per-test case basis?

Its unfortunate and we should fix that (though I'm not saying you need to for this patch).

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0f0b200e02442edcad8df3979f652d66c6e52eb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message