impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"
Date Wed, 02 Aug 2017 18:27:33 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3894: Change the behavior parsing date "YY"
......................................................................


Patch Set 13:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/7530/13/be/src/runtime/timestamp-parse-util.cc
File be/src/runtime/timestamp-parse-util.cc:

Line 546:   if (realign_year) {
dcheck here that dt_ctx.century_start_ptime is a valid ptime to make sure it was actually
set properly, you can call is_special().


http://gerrit.cloudera.org:8080/#/c/7530/13/be/src/runtime/timestamp-parse-util.h
File be/src/runtime/timestamp-parse-util.h:

PS13, Line 140: century_start_ptime
how about
century_break_ptime ?

century start sounds like it should be 1900, 2000, etc.


PS13, Line 141:   /// The year of century_start_time.
              :   boost::gregorian::date::year_type century_start_year;
why store this instead of using ptime.date().year() ? I think that shouldn't require any conversion,
should be fast.


PS13, Line 152: start of century
century break


PS13, Line 155: SetCenturyStart
SetCenturyBreak


PS13, Line 163: Reset
I missed this before, but this should reset the new members.

Please set century_start_time to not_a_date_time


-- 
To view, visit http://gerrit.cloudera.org:8080/7530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message