impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"
Date Wed, 02 Aug 2017 15:14:22 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3894: Change the behavior parsing date "YY"
......................................................................


Patch Set 9:

(1 comment)

I followed up with Greg, he said there's no right behavior when you don't specify all 4 years
which makes sense, so this behavior is fine.

Please address the other comments for now, though.

http://gerrit.cloudera.org:8080/#/c/7530/9//COMMIT_MSG
Commit Message:

PS9, Line 11: same as Hive's
> Hive's implementation is at . https://github.com/apache/hive/blob/master/hp
Thanks! Please mention this in the commit message and in the code.


-- 
To view, visit http://gerrit.cloudera.org:8080/7530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message