impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface
Date Wed, 02 Aug 2017 00:40:39 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface
......................................................................


Patch Set 3:

(2 comments)

> (2 comments)
 > 
 > I think you need to replace the types of the objects with their
 > base classes where appropriate. For example, ExecEnv::data_stream_mgr_
 > needs to be a DataStreamMgrBase.

Oops, sorry. Forgot to make that change. Updated it in the next patch set.

http://gerrit.cloudera.org:8080/#/c/7542/4/be/src/runtime/data-stream-mgr.h
File be/src/runtime/data-stream-mgr.h:

Line 71:   virtual std::shared_ptr<DataStreamRecvr> CreateRecvr(RuntimeState* state,
> not virtual?
Done


Line 82:   /// Returns OK if successful, error status otherwise.
> you'll need to mark the inherited methods as 'override', or clang-tidy will
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message