impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface
Date Tue, 01 Aug 2017 22:53:28 GMT
Sailesh Mukil has uploaded a new patch set (#4).

Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface

IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface

This patch introduces a dummy 'use_krpc' flag and creates an abstract
interface for the DataStreamRecvr/Mgr.

The DataStreamSender implements the same virtual interface as the
DataSink, so a pure virtual class for the DataStreamSender would
essentially be an empty class. Therefore, it is not implemented.

The new interfaces are pure virtual base classes and are named

The future KRPC patches will also implement the DataStream*Base

The 'use_krpc' flag defaults to 'false'. Cluster startup will abort
with an error if the flag is switched to 'true'.

Change-Id: I5d52245154e910529a68f53049520238eca16241
M be/src/exec/
M be/src/exec/
M be/src/runtime/CMakeLists.txt
A be/src/runtime/data-stream-mgr-base.h
M be/src/runtime/
M be/src/runtime/data-stream-mgr.h
A be/src/runtime/data-stream-recvr-base.h
M be/src/runtime/data-stream-recvr.h
M be/src/runtime/
M be/src/runtime/
M be/src/service/
11 files changed, 156 insertions(+), 5 deletions(-)

  git pull ssh:// refs/changes/42/7542/4
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>

View raw message