impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sherman (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections
Date Tue, 01 Aug 2017 22:25:12 GMT
John Sherman has posted comments on this change.

Change subject: IMPALA-5394: Handle blocked HS2 connections
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS4, Line 1963: exec_env->metrics(), FLAGS_fe_service_threads, ThriftServer::ThreadPool);
> Yes, let's remove it for network-perf-benchmark.cc.
Sorry, should that be "let's remove it from network-perf-benchmark"
or should it be "let's leave it for network-perf-benchmark"?

If I remove it from network-perf-benchmark, should I remove support of the ThreadPool type
from ThriftServer.cc?


-- 
To view, visit http://gerrit.cloudera.org:8080/7061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message