impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sherman (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections
Date Tue, 01 Aug 2017 22:08:51 GMT
John Sherman has posted comments on this change.

Change subject: IMPALA-5394: Handle blocked HS2 connections

Patch Set 4:

File be/src/service/

PS4, Line 1963: exec_env->metrics(), FLAGS_fe_service_threads, ThriftServer::ThreadPool);
> Let's make this change for beeswax as well.
Running this change through run-all-tests and changing the comment at 1954 to be:
"ODBC and Hue drivers do not support non-blocking servers." similar to the comment at line
1976. I'm guessing at the intent of the old comment.

After this change the only thing using ThreadPool server implementation is

Not sure what the is used for, but if nothing else is using ThreadedPool
implementation should I just remove support for it from ThriftServer() to prevent bit rot
in the unused code paths? Or just leave it be for future use (or just for the network-perf-benchmark
to use?)

PS4, Line 1985: Threaded
> Maybe we can just remove Threaded and ThreadPool and just pass in the numbe
Does it matter that FLAG_enable_accept_queue_server can be turned to false and that these
thread limits will not be enforced? Or at this point is there enough confidence that the accept_queue_server
is good/stable enough and won't be disabled? If that is the case, should the flag be deprecated
and the special case code be removed for disabling it?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Sherman <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: John Sherman <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-HasComments: Yes

View raw message