impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()
Date Tue, 01 Aug 2017 20:59:13 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()
......................................................................


Patch Set 1:

I think the side-effects are more controlled now. Previously if the MemTracker was destroyed,
we would have touched invalid memory. Now at least the memory is valid so the behaviour is
defined.

The new DCHECK in UnregisterFromParent() means the leak check is just as strong on the debug
build.

-- 
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message