impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5616: Add --enable minidumps startup flag
Date Tue, 01 Aug 2017 19:03:03 GMT
Hello Matthew Jacobs, Thomas Tauber-Marshall,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7541

to look at the new patch set (#3).

Change subject: IMPALA-5616: Add --enable_minidumps startup flag
......................................................................

IMPALA-5616: Add --enable_minidumps startup flag

If set to 'false', this flag will disable registration of the Breakpad
signal handlers during startup. The default value is 'true'. This does
not affect the ability to disable the handlers by specifying an empty
value for --minidump_path.

This change adds a test to test_breakpad.py.

Change-Id: Ie2039b9140e1c281810b27b76140e2105198bc37
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M tests/custom_cluster/test_breakpad.py
3 files changed, 14 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/7541/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2039b9140e1c281810b27b76140e2105198bc37
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message