impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5616: Add --enable minidumps startup flag
Date Tue, 01 Aug 2017 15:41:59 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5616: Add --enable_minidumps startup flag
......................................................................


Patch Set 1:

(2 comments)

Thank you for the review, please see PS2.

http://gerrit.cloudera.org:8080/#/c/7541/1//COMMIT_MSG
Commit Message:

Line 8: 
> A sentence or two here, eg. 'if true, skips registering...', what the defau
Done


http://gerrit.cloudera.org:8080/#/c/7541/1/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

Line 86:   def start_cluster_without_minidumps(self):
> This isn't used anywhere now, right?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2039b9140e1c281810b27b76140e2105198bc37
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message