impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down
Date Tue, 01 Aug 2017 07:35:28 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-1470: Fix error message with catalog down
......................................................................


IMPALA-1470: Fix error message with catalog down

When the catalog server cannot be reached, currently impala client would report
a NullpointerException to shell with no context. The improved error message
with this patch is:
> ERROR: InternalException: Error requesting prioritized load:
Couldn't open transport for localhost:26000 (connect() failed: Connection refused)
> Error making an RPC call to Catalog server.

The bug is when the client gets an RPC error, it tries to box the error into a
field of a Thrift struct but does not set the optional field to be present.
This patch makes the status field in TPrioritizeLoadResponse required.

Change-Id: Ic695faf89b146bdaa145aaca87f85579137b67c5
Reviewed-on: http://gerrit.cloudera.org:8080/7539
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/service/fe-support.cc
M common/thrift/CatalogService.thrift
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic695faf89b146bdaa145aaca87f85579137b67c5
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message