Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4F226200CCC for ; Fri, 21 Jul 2017 23:41:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4D4F516DF5B; Fri, 21 Jul 2017 21:41:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 93EE416DF57 for ; Fri, 21 Jul 2017 23:41:17 +0200 (CEST) Received: (qmail 37106 invoked by uid 500); 21 Jul 2017 21:41:16 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 37089 invoked by uid 99); 21 Jul 2017 21:41:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Jul 2017 21:41:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 28723C06B8 for ; Fri, 21 Jul 2017 21:41:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id gCeKgFXyGTgX for ; Fri, 21 Jul 2017 21:41:05 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1520A5FCB9 for ; Fri, 21 Jul 2017 21:41:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6LLf3GL030903; Fri, 21 Jul 2017 21:41:03 GMT Date: Fri, 21 Jul 2017 21:41:03 +0000 From: "Taras Bobrovytsky (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: tbobrovytsky@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5679=3A_Fix_Parquet_count=28*=29_with_group_by_string=0A?= X-Gerrit-Change-Id: I225547574c2b2259ca81cb642d082e151f3bed6b X-Gerrit-ChangeURL: X-Gerrit-Commit: ca447f1dc1df3f2bf8666d1d59ade2846a604625 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 21 Jul 2017 21:41:18 -0000 Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7481 Change subject: IMPALA-5679: Fix Parquet count(*) with group by string ...................................................................... IMPALA-5679: Fix Parquet count(*) with group by string In a recent patch (IMPALA-5036) a bug was introduced where a count(*) query with a group by a string partition column returned incorrect results. Data was being written into the tuple at an incorrect offset. Testing: - Added an end to end test where we are selecting from a table partitioned by string. Change-Id: I225547574c2b2259ca81cb642d082e151f3bed6b --- M be/src/exec/hdfs-scan-node-base.h M testdata/workloads/functional-query/queries/QueryTest/parquet-stats-agg.test M tests/query_test/test_aggregation.py 3 files changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/7481/1 -- To view, visit http://gerrit.cloudera.org:8080/7481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I225547574c2b2259ca81cb642d082e151f3bed6b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky