Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B8567200CCB for ; Thu, 20 Jul 2017 19:57:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B690B16BCB8; Thu, 20 Jul 2017 17:57:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 084EF16BCB6 for ; Thu, 20 Jul 2017 19:57:14 +0200 (CEST) Received: (qmail 86776 invoked by uid 500); 20 Jul 2017 17:57:14 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 86761 invoked by uid 99); 20 Jul 2017 17:57:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jul 2017 17:57:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8783CC00A9 for ; Thu, 20 Jul 2017 17:57:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id zRrGlvdRGNVE for ; Thu, 20 Jul 2017 17:57:12 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BCF965F56A for ; Thu, 20 Jul 2017 17:57:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6KHvBF3008931; Thu, 20 Jul 2017 17:57:11 GMT Date: Thu, 20 Jul 2017 17:57:11 +0000 From: "Henry Robinson (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: henry@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5688=3A_Reduce_run-time_of_a_couple_of_expr-test_heavy-hitters=0A?= X-Gerrit-Change-Id: I2962115734aff8dcaae0cc405274765105e31572 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3f98e126c5602f383b438be573addffba10ed6ca MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 20 Jul 2017 17:57:15 -0000 Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7474 Change subject: IMPALA-5688: Reduce run-time of a couple of expr-test heavy-hitters ...................................................................... IMPALA-5688: Reduce run-time of a couple of expr-test heavy-hitters Two tests (LongReverse and the base64 tests in StringFunctions) run their tests over all lengths from 0..{{some length}}. Both take several minutes to complete. This adds a lot of runtime for not much more confidence. Pick a set of 'interesting' (including powers-of-two, prime numbers, edge-cases) lengths to run them over instead. Test time is reduced by >150s on my desktop machine in debug mode. Change-Id: I2962115734aff8dcaae0cc405274765105e31572 --- M be/src/exprs/expr-test.cc 1 file changed, 9 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/7474/1 -- To view, visit http://gerrit.cloudera.org:8080/7474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2962115734aff8dcaae0cc405274765105e31572 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson