Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2F423200CC9 for ; Mon, 17 Jul 2017 21:15:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2DCE6161592; Mon, 17 Jul 2017 19:15:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 830FD165986 for ; Mon, 17 Jul 2017 21:15:18 +0200 (CEST) Received: (qmail 91799 invoked by uid 500); 17 Jul 2017 19:15:17 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 91788 invoked by uid 99); 17 Jul 2017 19:15:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2017 19:15:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 200681A073B for ; Mon, 17 Jul 2017 19:15:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id xQlEqWhbpmld for ; Mon, 17 Jul 2017 19:15:13 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 561725F523 for ; Mon, 17 Jul 2017 19:15:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6HJFAa5004637; Mon, 17 Jul 2017 19:15:10 GMT Date: Mon, 17 Jul 2017 19:15:10 +0000 From: "Henry Robinson (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: henry@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5670=3A_Misc=2E_tidying_of_ExecEnv=0A?= X-Gerrit-Change-Id: I3886bc0edfae0c65c302e1a1812632e60668cd4c X-Gerrit-ChangeURL: X-Gerrit-Commit: 45059ecfe3bc4b833cd5c8384fa26581b5f8e034 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 17 Jul 2017 19:15:19 -0000 Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7445 Change subject: IMPALA-5670: Misc. tidying of ExecEnv ...................................................................... IMPALA-5670: Misc. tidying of ExecEnv * Remove duplicated c'tor code for ExecEnv() and delegate it onto 6-argument c'tor. * Make some RM-related flags hidden * Remove unused and untested 'use_statestore' branch in ExecEnv which created a scheduler with static hosts rather than those sent by the statestore. * Remove corresponding scheduler c'tor to handle the above path. Change-Id: I3886bc0edfae0c65c302e1a1812632e60668cd4c --- M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/scheduling/scheduler.cc M be/src/scheduling/scheduler.h 4 files changed, 49 insertions(+), 149 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/7445/1 -- To view, visit http://gerrit.cloudera.org:8080/7445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3886bc0edfae0c65c302e1a1812632e60668cd4c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson