Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 559D3200CE9 for ; Sat, 15 Jul 2017 00:11:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5437516E9CA; Fri, 14 Jul 2017 22:11:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9A99E16E9C7 for ; Sat, 15 Jul 2017 00:11:01 +0200 (CEST) Received: (qmail 20154 invoked by uid 500); 14 Jul 2017 22:11:00 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 20100 invoked by uid 99); 14 Jul 2017 22:11:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2017 22:11:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 237121A04A8 for ; Fri, 14 Jul 2017 22:11:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PaW_iPVceBis for ; Fri, 14 Jul 2017 22:10:59 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id CD09560DA9 for ; Fri, 14 Jul 2017 22:10:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6EMAwD9018461; Fri, 14 Jul 2017 22:10:58 GMT Date: Fri, 14 Jul 2017 22:10:58 +0000 From: "Sailesh Mukil (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho Message-ID: Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5592=3A_Fix_computation_of_uncompressed_row_batch_size=0A?= X-Gerrit-Change-Id: Ic8d285d1e4a1aa97c98c505351c18fea04c60311 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8b285f6f2db67caff86be5bc6b0ffebd306ae912 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 14 Jul 2017 22:11:02 -0000 Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7434 Change subject: IMPALA-5592: Fix computation of uncompressed row batch size ...................................................................... IMPALA-5592: Fix computation of uncompressed row batch size The uncompressed row batch size is the size of a row batch if the tuple data is sent without compression. It's computed by the following formula: serialized row batch size - compressed tuple data size + uncompressed tuple data size The existing code is using the wrong field for the compressed tuple data size and it causes uncompressed data size to be always identical to the compressed row batch size. This change fixes the problem by using the right field for the compressed tuple data size. Change-Id: Ic8d285d1e4a1aa97c98c505351c18fea04c60311 --- M be/src/runtime/data-stream-sender.cc 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/7434/1 -- To view, visit http://gerrit.cloudera.org:8080/7434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic8d285d1e4a1aa97c98c505351c18fea04c60311 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Michael Ho