Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 920E3200CBD for ; Thu, 6 Jul 2017 22:51:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 90A9D167693; Thu, 6 Jul 2017 20:51:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D7DDC167691 for ; Thu, 6 Jul 2017 22:51:44 +0200 (CEST) Received: (qmail 88495 invoked by uid 500); 6 Jul 2017 20:51:44 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 88479 invoked by uid 99); 6 Jul 2017 20:51:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 20:51:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5B0FCC06D2 for ; Thu, 6 Jul 2017 20:51:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 00fzc949-UwG for ; Thu, 6 Jul 2017 20:51:42 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6B64E5F341 for ; Thu, 6 Jul 2017 20:51:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v66KpfFx001447; Thu, 6 Jul 2017 20:51:41 GMT Date: Thu, 6 Jul 2017 20:51:41 +0000 From: "Dan Hecht (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5580=3A_fix_Java_UDFs_that_return_NULL_strings=0A?= X-Gerrit-Change-Id: I34d288aad66a2609484058c9a177c02200cb6a6e X-Gerrit-ChangeURL: X-Gerrit-Commit: 52fe585c8485127541f7828feee111cbfe6f58ce MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 06 Jul 2017 20:51:45 -0000 Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/7364 Change subject: IMPALA-5580: fix Java UDFs that return NULL strings ...................................................................... IMPALA-5580: fix Java UDFs that return NULL strings In commit 381e719, we accidently made it so that is_null=true StringVals became is_null=false with len=0. Fix that and add a regression test. Change-Id: I34d288aad66a2609484058c9a177c02200cb6a6e --- M be/src/exprs/hive-udf-call.cc M testdata/workloads/functional-query/queries/QueryTest/java-udf.test 2 files changed, 28 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/7364/1 -- To view, visit http://gerrit.cloudera.org:8080/7364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34d288aad66a2609484058c9a177c02200cb6a6e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht