Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3BDC5200CEB for ; Sat, 29 Jul 2017 03:10:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3A3BD16DD70; Sat, 29 Jul 2017 01:10:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7FA4D16DD6D for ; Sat, 29 Jul 2017 03:10:25 +0200 (CEST) Received: (qmail 78974 invoked by uid 500); 29 Jul 2017 01:10:24 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 78956 invoked by uid 99); 29 Jul 2017 01:10:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Jul 2017 01:10:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2E73EC35CC for ; Sat, 29 Jul 2017 01:10:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JNmTZlr5TTP7 for ; Sat, 29 Jul 2017 01:10:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1C6005F6C7 for ; Sat, 29 Jul 2017 01:10:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6T1A5XI002438; Sat, 29 Jul 2017 01:10:05 GMT Message-Id: <201707290110.v6T1A5XI002438@ip-10-146-233-104.ec2.internal> Date: Sat, 29 Jul 2017 01:10:04 +0000 From: "Tianyi Wang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Greg Rahn Reply-To: twang@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3894=3A_Change_the_behavior_parsing_date_=22YY=22=0A?= X-Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8fe78f65d0aa9ed958de30a66019dcdbbd95eb7d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Sat, 29 Jul 2017 01:10:26 -0000 Tianyi Wang has uploaded a new patch set (#8). Change subject: IMPALA-3894: Change the behavior parsing date "YY" ...................................................................... IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running unix_timestamp(string, string) function. Before the change Impala directly adds 2000 to the year parsed. Behavior after change is the same as Hive's, shifting the parsed date into the interval [current time - 80 years, current time + 20 years). In 2017, given query > select from_unixtime(unix_timestamp('31-AUG-94', 'dd-MMM-yy'),'yyyyMMdd'); Impala would output 20940831 before the change and 19940831 with this patch applied. unix_timestamp function with other forms of parameters is not affected. Test: add 4 test cases to timestamp-test.cc, testing the edge cases of 2-year format. Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 --- M be/src/exprs/timestamp-functions.cc M be/src/runtime/timestamp-parse-util.cc M be/src/runtime/timestamp-parse-util.h M be/src/runtime/timestamp-test.cc 4 files changed, 38 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/7530/8 -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Tim Armstrong