Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1A75B200CD3 for ; Fri, 28 Jul 2017 20:10:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 18E3416D496; Fri, 28 Jul 2017 18:10:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5EF0F16D494 for ; Fri, 28 Jul 2017 20:10:27 +0200 (CEST) Received: (qmail 92082 invoked by uid 500); 28 Jul 2017 18:10:26 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 92065 invoked by uid 99); 28 Jul 2017 18:10:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jul 2017 18:10:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BB157C00A6 for ; Fri, 28 Jul 2017 18:10:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ESaVmFEIOf-L for ; Fri, 28 Jul 2017 18:10:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 33AA25F6C7 for ; Fri, 28 Jul 2017 18:10:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6SIALc0027685; Fri, 28 Jul 2017 18:10:21 GMT Message-Id: <201707281810.v6SIALc0027685@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Jul 2017 18:10:21 +0000 From: "Pooja Nilangekar (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Lars Volker Reply-To: pooja.nilangekar@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Build_a_ConcatenatedStreams_wrapper_for_ScannerContext=3A=3AStream=0A?= X-Gerrit-Change-Id: I026f7a005ba4d6fc412ca0884f4fa0459da9c885 X-Gerrit-ChangeURL: X-Gerrit-Commit: 552591ad64bd63081187fb0feac86479aa995ed2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 28 Jul 2017 18:10:28 -0000 Pooja Nilangekar has uploaded a new patch set (#3). Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream ...................................................................... Build a ConcatenatedStreams wrapper for ScannerContext::Stream The ConcatenatedStreams class keeps track of a vector of streams which can be utilized by the BaseScalarColumnReader to read transparently from a list of streams. The ConcatenatedStreams would hide the different ScanRanges from the caller and provide the abstraction of a single stream. The class uses a list of streams and a index to point to the current active stream. The class moves to the next stream once the current stream reaches its end of stream. Testing: The existing test_scanners.py test was used to validate the correctness of the ConcatenatedStreams. Change-Id: I026f7a005ba4d6fc412ca0884f4fa0459da9c885 --- M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/parquet-column-readers.h M be/src/exec/scanner-context.cc M be/src/exec/scanner-context.h 4 files changed, 111 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/7513/3 -- To view, visit http://gerrit.cloudera.org:8080/7513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I026f7a005ba4d6fc412ca0884f4fa0459da9c885 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Pooja Nilangekar