Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C087A200CD3 for ; Fri, 28 Jul 2017 19:40:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BEE5916D3EB; Fri, 28 Jul 2017 17:40:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 10C0116D3E9 for ; Fri, 28 Jul 2017 19:40:05 +0200 (CEST) Received: (qmail 2705 invoked by uid 500); 28 Jul 2017 17:40:05 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 2693 invoked by uid 99); 28 Jul 2017 17:40:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jul 2017 17:40:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 90FC81A1B79 for ; Fri, 28 Jul 2017 17:40:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id BUkEwaKDJp9e for ; Fri, 28 Jul 2017 17:40:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 50D235FD38 for ; Fri, 28 Jul 2017 17:40:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6SHe13l026418; Fri, 28 Jul 2017 17:40:01 GMT Message-Id: <201707281740.v6SHe13l026418@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Jul 2017 17:40:01 +0000 From: "Sailesh Mukil (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Vincent Tran Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5336=3A_Fix_partition_pruning_when_column_is_cast=0A?= X-Gerrit-Change-Id: I94f597a6589f5e34d2b74abcd29be77c4161cd99 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4337aa961fcb4dece41144fafb4bea5aad462671 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 28 Jul 2017 17:40:07 -0000 Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast ...................................................................... Patch Set 1: Code-Review+1 The explanation seems acceptable to me, we won't be missing out on a huge optimization by doing this. Plus, as this is a correctness issue, I too feel this is the right thing to do. -- To view, visit http://gerrit.cloudera.org:8080/7521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94f597a6589f5e34d2b74abcd29be77c4161cd99 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Vincent Tran Gerrit-HasComments: No