Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 90FE9200CE1 for ; Fri, 28 Jul 2017 02:26:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8DCCA16BED5; Fri, 28 Jul 2017 00:26:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D2B8F16BED2 for ; Fri, 28 Jul 2017 02:26:10 +0200 (CEST) Received: (qmail 86735 invoked by uid 500); 28 Jul 2017 00:26:10 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 86724 invoked by uid 99); 28 Jul 2017 00:26:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jul 2017 00:26:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5A860180647 for ; Fri, 28 Jul 2017 00:26:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MoZOjBMIdHWJ for ; Fri, 28 Jul 2017 00:26:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7AF925FB32 for ; Fri, 28 Jul 2017 00:26:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6S0Q73a014265; Fri, 28 Jul 2017 00:26:07 GMT Message-Id: <201707280026.v6S0Q73a014265@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Jul 2017 00:26:07 +0000 From: "Tim Armstrong (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Greg Rahn Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3894=3A_Changed_the_behavior_parsing_2-digit_year_values=0A?= X-Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 X-Gerrit-ChangeURL: X-Gerrit-Commit: a7f7100fafb1238bc49bd739b2c62c9cd50fa573 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 28 Jul 2017 00:26:11 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values ...................................................................... Patch Set 4: Greg, you've got a lot of experience looking at date/time functions. What do you think about emulating Hive's behaviour here? It looks like it factors in the current year when determining how to interpret a 2 digit yet. -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No