Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 16252200CD2 for ; Thu, 27 Jul 2017 21:41:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 150FE168732; Thu, 27 Jul 2017 19:41:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 50EA1168E05 for ; Thu, 27 Jul 2017 21:41:10 +0200 (CEST) Received: (qmail 42138 invoked by uid 500); 27 Jul 2017 19:41:09 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 42127 invoked by uid 99); 27 Jul 2017 19:41:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jul 2017 19:41:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E1C0A180704 for ; Thu, 27 Jul 2017 19:41:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VWX-MgYiHNTI for ; Thu, 27 Jul 2017 19:41:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 317005F242 for ; Thu, 27 Jul 2017 19:41:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6RJf7j2005064; Thu, 27 Jul 2017 19:41:07 GMT Message-Id: <201707271941.v6RJf7j2005064@ip-10-146-233-104.ec2.internal> Date: Thu, 27 Jul 2017 19:41:07 +0000 From: "Bharath Vissapragada (Code Review)" To: Taras Bobrovytsky , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5689=3A_Avoid_inverting_non-equi_right_joins=0A?= X-Gerrit-Change-Id: I91ba66fe30139fcd44d4615a142f183266800aab X-Gerrit-ChangeURL: X-Gerrit-Commit: 168d985188911d1dfd29254eddb4c6fb5008dfa1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 27 Jul 2017 19:41:11 -0000 Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi right joins ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Looks like its good to get this in quickly. +2'ing since the change is simple. (Please fix the commit subject and content before GVO). http://gerrit.cloudera.org:8080/#/c/7476/3//COMMIT_MSG Commit Message: PS3, Line 7: right joins left joins? -- To view, visit http://gerrit.cloudera.org:8080/7476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91ba66fe30139fcd44d4615a142f183266800aab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes