Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E3A97200CD1 for ; Wed, 26 Jul 2017 13:06:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E2737162889; Wed, 26 Jul 2017 11:06:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D2FA01622F9 for ; Wed, 26 Jul 2017 13:06:13 +0200 (CEST) Received: (qmail 63111 invoked by uid 500); 26 Jul 2017 11:06:13 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 63080 invoked by uid 99); 26 Jul 2017 11:06:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jul 2017 11:06:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 87E02C040F for ; Wed, 26 Jul 2017 11:06:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id aU7dWwN6Uvd3 for ; Wed, 26 Jul 2017 11:06:09 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 892855FDDC for ; Wed, 26 Jul 2017 11:06:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6QB61Lq002684; Wed, 26 Jul 2017 11:06:01 GMT Message-Id: <201707261106.v6QB61Lq002684@ip-10-146-233-104.ec2.internal> Date: Wed, 26 Jul 2017 11:06:00 +0000 From: "Gabor Kaszab (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Attila Jeges , Dan Hecht , Tim Armstrong , Laszlo Gaal Reply-To: gaborkaszab@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5511=3A_Add_process_start_time_to_debug_web_page=0A?= X-Gerrit-Change-Id: I05ae2f80835b1b0e4bc3b38731778ba0871338a4 X-Gerrit-ChangeURL: X-Gerrit-Commit: e2bc04ef96305223bc275f0d0262fa68b91dc7c8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 26 Jul 2017 11:06:15 -0000 Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7363 to look at the new patch set (#12). Change subject: IMPALA-5511: Add process start time to debug web page ...................................................................... IMPALA-5511: Add process start time to debug web page Read the start date and time of the impalad, catalogd and statestored processes for the Debug Web UI. Uses the stat command on the /proc/ directory and format the date with the date command to local time format. Change-Id: I05ae2f80835b1b0e4bc3b38731778ba0871338a4 --- M be/src/catalog/catalogd-main.cc M be/src/service/impala-server.cc M be/src/service/impalad-main.cc M be/src/statestore/statestored-main.cc M be/src/util/CMakeLists.txt A be/src/util/common-metrics.cc A be/src/util/common-metrics.h M be/src/util/default-path-handlers.cc M be/src/util/default-path-handlers.h M be/src/util/impalad-metrics.cc M be/src/util/impalad-metrics.h M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h M common/thrift/metrics.json M www/root.tmpl 16 files changed, 146 insertions(+), 51 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/7363/12 -- To view, visit http://gerrit.cloudera.org:8080/7363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I05ae2f80835b1b0e4bc3b38731778ba0871338a4 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong