Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3D863200CDE for ; Tue, 25 Jul 2017 00:20:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3BF54165DA8; Mon, 24 Jul 2017 22:20:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8246C165DA6 for ; Tue, 25 Jul 2017 00:20:16 +0200 (CEST) Received: (qmail 8854 invoked by uid 500); 24 Jul 2017 22:20:15 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 8838 invoked by uid 99); 24 Jul 2017 22:20:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2017 22:20:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ED9E8C1201 for ; Mon, 24 Jul 2017 22:20:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id z9wqPOVkYWXD for ; Mon, 24 Jul 2017 22:20:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 74FA05FB84 for ; Mon, 24 Jul 2017 22:20:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6OMK3JA000351; Mon, 24 Jul 2017 22:20:03 GMT Message-Id: <201707242220.v6OMK3JA000351@ip-10-146-233-104.ec2.internal> Date: Mon, 24 Jul 2017 22:20:03 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Sailesh Mukil , Matthew Jacobs Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_Add_linker=27s_version_script_for_OpenSSL_library=2E=0A?= X-Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89 X-Gerrit-ChangeURL: X-Gerrit-Commit: cc5d24f54bbd56022c336b2e6a8a44f2fc055b24 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 24 Jul 2017 22:20:17 -0000 Michael Ho has posted comments on this change. Change subject: Add linker's version script for OpenSSL library. ...................................................................... Patch Set 4: For question 2, I tried looking into how Ubuntu generated the version script file but didn't find much during the brief search. -- To view, visit http://gerrit.cloudera.org:8080/7484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89 Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No