Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4BF6B200CCF for ; Mon, 24 Jul 2017 23:40:33 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4A912165C95; Mon, 24 Jul 2017 21:40:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 90231165C8C for ; Mon, 24 Jul 2017 23:40:32 +0200 (CEST) Received: (qmail 26353 invoked by uid 500); 24 Jul 2017 21:40:31 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 26342 invoked by uid 99); 24 Jul 2017 21:40:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2017 21:40:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2E2251A1CE4 for ; Mon, 24 Jul 2017 21:40:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 1Grrw5H0d_rR for ; Mon, 24 Jul 2017 21:40:30 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 32F035F2F1 for ; Mon, 24 Jul 2017 21:40:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6OLeTg0031476; Mon, 24 Jul 2017 21:40:29 GMT Message-Id: <201707242140.v6OLeTg0031476@ip-10-146-233-104.ec2.internal> Date: Mon, 24 Jul 2017 21:40:29 +0000 From: "Bharath Vissapragada (Code Review)" To: Bikramjeet Vig , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4795=3A_Allow_fetching_function_obj_from_catalog_using_signature=0A?= X-Gerrit-Change-Id: I2cfad0213a79d39b77ad9aff701a93f93be4bf7f X-Gerrit-ChangeURL: X-Gerrit-Commit: eac00b2f9ce0bb192fe85e7b2cb5ed6c84ae590c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 24 Jul 2017 21:40:33 -0000 Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7479/1/fe/src/main/java/org/apache/impala/catalog/Function.java File fe/src/main/java/org/apache/impala/catalog/Function.java: Line 360: throw new IllegalStateException("Expected function type to be either UDA or UDF."); > This seems like a reasonable thing to do later, but I'm not sure if this wi - Currently we only store scalar/aggregate functions in the table params, basically native UDF/UDAs added by the users. We do that for permanent UDF/UDAs feature (test_permanent_udfs.py) - I agree that we can have corrupted blobs in some edge cases which can potentially hit this else, so a TODO should be good. -- To view, visit http://gerrit.cloudera.org:8080/7479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cfad0213a79d39b77ad9aff701a93f93be4bf7f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes