Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201707241957.v6OJvIEn029228@ip-10-146-233-104.ec2.internal>
Date: Mon, 24 Jul 2017 19:57:18 +0000
From: "John Russell (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Sailesh Mukil <sailesh@cloudera.com>, Greg Rahn <grahn@cloudera.com>
Reply-To: jrussell@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_=5BDOCS=5D_Take_out_not-production-ready_notice_from_ADLS_page=0A?=
In-Reply-To: <gerrit.1500918578000.I127b7806feca810503ba3dd000a8e972835e715a@gerrit.cloudera.org>
References: <gerrit.1500918578000.I127b7806feca810503ba3dd000a8e972835e715a@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Mon, 24 Jul 2017 19:57:32 -0000

John Russell has posted comments on this change.

Change subject: [DOCS] Take out not-production-ready notice from ADLS page
......................................................................


Patch Set 1:

(2 comments)

If the reusable element is never referenced, it's dead code from the perspective of output, but sure I'll take it out so the commit history is more emphatic on that point.

http://gerrit.cloudera.org:8080/#/c/7487/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 1118:       <note rev="2.9.0 IMPALA-5333" id="adls_production" type="important">
              :         <p>
              :           Currently, the ADLS support in Impala is preliminary and not
              :           fully tested. Do not use Impala with ADLS in a production environment.
              :         </p>
              :       </note>
> Don't we need to remove this as well?
Done


PS1, Line 1118:       <note rev="2.9.0 IMPALA-5333" id="adls_production" type="important">
              :         <p>
              :           Currently, the ADLS support in Impala is preliminary and not
              :           fully tested. Do not use Impala with ADLS in a production environment.
              :         </p>
              :       </note>
> IMO, yes, it should be removed as well.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I127b7806feca810503ba3dd000a8e972835e715a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes