Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 20D36200CCF for ; Mon, 24 Jul 2017 21:10:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1F791165962; Mon, 24 Jul 2017 19:10:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 64A03165946 for ; Mon, 24 Jul 2017 21:10:44 +0200 (CEST) Received: (qmail 35706 invoked by uid 500); 24 Jul 2017 19:10:43 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 35693 invoked by uid 99); 24 Jul 2017 19:10:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2017 19:10:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CE0F9C008C for ; Mon, 24 Jul 2017 19:10:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id O9SOBrEUHbQt for ; Mon, 24 Jul 2017 19:10:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B163B5FD3D for ; Mon, 24 Jul 2017 19:10:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6OJAUa4027035; Mon, 24 Jul 2017 19:10:30 GMT Message-Id: <201707241910.v6OJAUa4027035@ip-10-146-233-104.ec2.internal> Date: Mon, 24 Jul 2017 19:10:30 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Matthew Jacobs , Sailesh Mukil Reply-To: kwho@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_Add_linker=27s_version_script_for_OpenSSL_library=2E=0A?= X-Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3ad95c3d913c3423a0862f20d0a387e9b7b9f13a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 24 Jul 2017 19:10:45 -0000 Michael Ho has uploaded a new patch set (#3). Change subject: Add linker's version script for OpenSSL library. ...................................................................... Add linker's version script for OpenSSL library. Debian based distribution (e.g. Ubuntu) expects OpenSSL dynamically linked library to have been compiled with a version script to control the exported symbols for different versions of the library. Without this version info, one may get errors like the following: $IMPALA_HOME/be/build/latest/statestore/statestored: $IMPALA_HOME/toolchain/openssl-1.0.1p/lib/libssl.so.1.0.0: no version information available (required by $IMPALA_HOME/toolchain/kudu-1070e76/debug/lib/libkudu_client.so.0) This change copies part of the version script of Ubuntu's libssl 1.0.2g (https://launchpad.net/ubuntu/+source/openssl/1.0.2g-1ubuntu4) and uses it as part of building the shared library. Built Impala with this library and ran some sanity tests. Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89 --- M source/openssl/build.sh A source/openssl/openssl.ld 2 files changed, 4,638 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/84/7484/3 -- To view, visit http://gerrit.cloudera.org:8080/7484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil