Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C3264200CCC for ; Fri, 21 Jul 2017 17:44:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C1A2616D656; Fri, 21 Jul 2017 15:44:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 140B516D655 for ; Fri, 21 Jul 2017 17:43:59 +0200 (CEST) Received: (qmail 53052 invoked by uid 500); 21 Jul 2017 15:43:59 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53041 invoked by uid 99); 21 Jul 2017 15:43:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Jul 2017 15:43:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 68BD81805A2 for ; Fri, 21 Jul 2017 15:43:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 2QY9PyNc756Z for ; Fri, 21 Jul 2017 15:43:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 710D65F30C for ; Fri, 21 Jul 2017 15:43:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6LFhuLD024648; Fri, 21 Jul 2017 15:43:56 GMT Message-Id: <201707211543.v6LFhuLD024648@ip-10-146-233-104.ec2.internal> Date: Fri, 21 Jul 2017 15:43:56 +0000 From: "Kim Jin Chul (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Thomas Tauber-Marshall , Greg Rahn , Matthew Jacobs Reply-To: jinchul@gmail.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5529=3A_Add_additional_function_signatures_for_TRUNC=28=29=0A?= X-Gerrit-Change-Id: I856da9f817b948de3c72af60a0742b128398b4cf X-Gerrit-ChangeURL: X-Gerrit-Commit: 1353ca8f3c1c6c3eb5f2768890dcdcb4802660d9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 21 Jul 2017 15:44:00 -0000 Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7450/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: Line 2205: "Cannot resolve DECIMAL precision and scale from NULL type."); I have some questions for implicit type casting. I know that NULL is unknown, so NULL does not have a datatype. By the way, it seems implicit type conversion happens in the function calls. I guess NULL might be converted into DECIMAL type on the line 2205, but NULL might not be converted into DECIMAL type on the line 2204. I think there should be a precedence of datatypes. Would you let me know where I could find information for precedence rule in document/code? -- To view, visit http://gerrit.cloudera.org:8080/7450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I856da9f817b948de3c72af60a0742b128398b4cf Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kim Jin Chul Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes