Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B3CF4200CDA for ; Fri, 21 Jul 2017 00:58:53 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B25C816ADC1; Thu, 20 Jul 2017 22:58:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0520816ADBF for ; Fri, 21 Jul 2017 00:58:52 +0200 (CEST) Received: (qmail 60157 invoked by uid 500); 20 Jul 2017 22:58:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 60146 invoked by uid 99); 20 Jul 2017 22:58:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jul 2017 22:58:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 94E72C373E for ; Thu, 20 Jul 2017 22:58:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ee1D7Z8QLXiv for ; Thu, 20 Jul 2017 22:58:43 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 117B05F640 for ; Thu, 20 Jul 2017 22:58:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6KMwfkR016345; Thu, 20 Jul 2017 22:58:41 GMT Message-Id: <201707202258.v6KMwfkR016345@ip-10-146-233-104.ec2.internal> Date: Thu, 20 Jul 2017 22:58:41 +0000 From: "Mostafa Mokhtar (Code Review)" To: Bikramjeet Vig , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Matthew Jacobs , Tim Armstrong Reply-To: mmokhtar@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5275=3A_Avoid_printing_status_stack_trace_on_hot_paths=0A?= X-Gerrit-Change-Id: Ief083f558fba587381aa7fe8f99da279da02f1f2 X-Gerrit-ChangeURL: X-Gerrit-Commit: cfb1925693ea3d330fd522df23da1c57466d277f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 20 Jul 2017 22:58:53 -0000 Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7449/3//COMMIT_MSG Commit Message: Line 22: 5. In Status::MemLimitExceeded(), create Status object without What about the cancellation code path? -- To view, visit http://gerrit.cloudera.org:8080/7449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief083f558fba587381aa7fe8f99da279da02f1f2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes