Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C2EAC200CCA for ; Wed, 19 Jul 2017 20:33:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C14FE169A26; Wed, 19 Jul 2017 18:33:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 12C75169A25 for ; Wed, 19 Jul 2017 20:33:08 +0200 (CEST) Received: (qmail 1501 invoked by uid 500); 19 Jul 2017 18:33:08 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 1490 invoked by uid 99); 19 Jul 2017 18:33:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jul 2017 18:33:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8DB981A1AB5 for ; Wed, 19 Jul 2017 18:33:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id zkMyTO0nr9hP for ; Wed, 19 Jul 2017 18:33:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8DA205F6C8 for ; Wed, 19 Jul 2017 18:33:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6JIX5Hi018166; Wed, 19 Jul 2017 18:33:05 GMT Message-Id: <201707191833.v6JIX5Hi018166@ip-10-146-233-104.ec2.internal> Date: Wed, 19 Jul 2017 18:33:05 +0000 From: "Tim Armstrong (Code Review)" To: anujphadke , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Thomas Tauber-Marshall Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5586=3A_Null-aware_anti-join_can_take_a_long_time_to_cancel=0A?= X-Gerrit-Change-Id: I0800754d4ad31cbadbdfadc630c640963f3f6053 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5db8c733568a365e442f649da75da291fd434d5c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 19 Jul 2017 18:33:09 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5586: Null-aware anti-join can take a long time to cancel ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7393/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 1023: // This loop may run for a long time. Periodically check for cancellation. We still need the check in the outer loop in case there are many matched rows. -- To view, visit http://gerrit.cloudera.org:8080/7393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0800754d4ad31cbadbdfadc630c640963f3f6053 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes