Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BEF8D200CD6 for ; Mon, 17 Jul 2017 03:11:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BD45C163C67; Mon, 17 Jul 2017 01:11:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0F94E163C66 for ; Mon, 17 Jul 2017 03:11:48 +0200 (CEST) Received: (qmail 60929 invoked by uid 500); 17 Jul 2017 01:11:48 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 60917 invoked by uid 99); 17 Jul 2017 01:11:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2017 01:11:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D0DBE180633 for ; Mon, 17 Jul 2017 01:11:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WtqeVUM1u8BU for ; Mon, 17 Jul 2017 01:11:46 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 08A015F2EC for ; Mon, 17 Jul 2017 01:11:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6H1BbAC030083; Mon, 17 Jul 2017 01:11:38 GMT Message-Id: <201707170111.v6H1BbAC030083@ip-10-146-233-104.ec2.internal> Date: Mon, 17 Jul 2017 01:11:37 +0000 From: "Donghui Xu (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , Henry Robinson , Bharath Vissapragada Reply-To: xu.donghui@zte.com.cn X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5513=3A_Fix_display_message_exception_when_using_invalid_KEYVAL=0A?= X-Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8f511550466940fbcfdc1ab65dbf0f2e4a98bbd6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 17 Jul 2017 01:11:49 -0000 Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL ...................................................................... Patch Set 7: Code-Review+1 Hi Bharath, I have merged the test case and carried your Code-Review+1. Would Jim please review this code again? Thanks. -- To view, visit http://gerrit.cloudera.org:8080/7187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Donghui Xu Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No