Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A750C200CD4 for ; Sat, 15 Jul 2017 08:08:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A5C1916E019; Sat, 15 Jul 2017 06:08:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EBB0316E016 for ; Sat, 15 Jul 2017 08:08:55 +0200 (CEST) Received: (qmail 63346 invoked by uid 500); 15 Jul 2017 06:08:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 63335 invoked by uid 99); 15 Jul 2017 06:08:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Jul 2017 06:08:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 44D9FC00B6 for ; Sat, 15 Jul 2017 06:08:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id t0Jdhsl9Uqrz for ; Sat, 15 Jul 2017 06:08:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E3D5B5FBE6 for ; Sat, 15 Jul 2017 06:08:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6F68meA025347; Sat, 15 Jul 2017 06:08:48 GMT Message-Id: <201707150608.v6F68meA025347@ip-10-146-233-104.ec2.internal> Date: Sat, 15 Jul 2017 06:08:48 +0000 From: "Donghui Xu (Code Review)" To: Bharath Vissapragada , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Jim Apple Reply-To: xu.donghui@zte.com.cn X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5513=3A_Fix_display_message_exception_when_using_invalid_KEYVAL=0A?= X-Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8f511550466940fbcfdc1ab65dbf0f2e4a98bbd6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Sat, 15 Jul 2017 06:08:56 -0000 Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7187 to look at the new patch set (#7). Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL ...................................................................... IMPALA-5513: Fix display message exception when using invalid KEYVAL Function print_to_stderr() has a syntax error when an error message is displayed. I solved this problem by exchanging the position of variable and the subsequent strings in function print_to_stderr(). Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6 --- M shell/impala_shell.py M tests/shell/test_shell_commandline.py 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7187/7 -- To view, visit http://gerrit.cloudera.org:8080/7187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Donghui Xu Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple