Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3A0DF200CD3 for ; Fri, 14 Jul 2017 00:03:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3841B16CFCF; Thu, 13 Jul 2017 22:03:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7E5EB16CFCE for ; Fri, 14 Jul 2017 00:03:20 +0200 (CEST) Received: (qmail 9585 invoked by uid 500); 13 Jul 2017 22:03:19 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 9572 invoked by uid 99); 13 Jul 2017 22:03:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jul 2017 22:03:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 427C8180844 for ; Thu, 13 Jul 2017 22:03:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id mDNwd3-3AiYU for ; Thu, 13 Jul 2017 22:03:17 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E9A545FC7B for ; Thu, 13 Jul 2017 22:03:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6DM3ERL004081; Thu, 13 Jul 2017 22:03:14 GMT Message-Id: <201707132203.v6DM3ERL004081@ip-10-146-233-104.ec2.internal> Date: Thu, 13 Jul 2017 22:03:14 +0000 From: "Jim Apple (Code Review)" To: Kim Jin Chul , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5116=3A_Remove_deprecated_hash_*_types_in_gutil=0A?= X-Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7e244d4282527df252aa237fbf7d926223e59069 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 13 Jul 2017 22:03:21 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h File be/src/gutil/hash/hash.h: Line 222 > You're right. std::hash template class is specialized between 1 byte and 8 OK, so it looks like you've added it back in. Before we can decide if it should stay or not, let'd understand why it didn't break the build before. Line 278 > You're right. It should make wrong result or corruption. So, do you need it to still exist, and if so, how do you make sure std::hash, which may not be __gnu_cxx::hash, is specialized? -- To view, visit http://gerrit.cloudera.org:8080/7414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kim Jin Chul Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Kim Jin Chul Gerrit-HasComments: Yes