Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 74458200CC4 for ; Thu, 13 Jul 2017 23:59:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 726D516CFBE; Thu, 13 Jul 2017 21:59:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B89DF16CFBA for ; Thu, 13 Jul 2017 23:59:40 +0200 (CEST) Received: (qmail 565 invoked by uid 500); 13 Jul 2017 21:59:40 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 554 invoked by uid 99); 13 Jul 2017 21:59:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jul 2017 21:59:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 451201A06BE for ; Thu, 13 Jul 2017 21:59:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id QQjkcyZ_VYkH for ; Thu, 13 Jul 2017 21:59:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BF10C5F6C6 for ; Thu, 13 Jul 2017 21:59:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6DLxaYN003768; Thu, 13 Jul 2017 21:59:36 GMT Message-Id: <201707132159.v6DLxaYN003768@ip-10-146-233-104.ec2.internal> Date: Thu, 13 Jul 2017 21:59:35 +0000 From: "Bharath Vissapragada (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5657=3A_Fix_a_couple_of_bugs_with_FunctionCallExpr_and_IGNORE_NULLS=0A?= X-Gerrit-Change-Id: I723897886c95763c3f29d6f24c4d9e7d43898ade X-Gerrit-ChangeURL: X-Gerrit-Commit: ba91ae4bec1ae94d4717105195131c77eb7db4e7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 13 Jul 2017 21:59:41 -0000 Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-5657: Fix a couple of bugs with FunctionCallExpr and IGNORE NULLS ...................................................................... IMPALA-5657: Fix a couple of bugs with FunctionCallExpr and IGNORE NULLS Bugs: - FunctionCallExpr's toSql() doesn't include IGNORE NULLS if present causing view definitions to break and leading to incorrect results. - FunctionCallExpr's clone() implementation doesn't carry forward IGNORE NULLS option if present. One case that breaks with this is querying views containing analytic exprs causing wrong plans. Fixed both the bugs and added a test that can reliably reproduce this. Change-Id: I723897886c95763c3f29d6f24c4d9e7d43898ade --- M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test 3 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/7416/2 -- To view, visit http://gerrit.cloudera.org:8080/7416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I723897886c95763c3f29d6f24c4d9e7d43898ade Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Matthew Jacobs