Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 56DEB200CD2 for ; Thu, 13 Jul 2017 07:03:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5534916AC7E; Thu, 13 Jul 2017 05:03:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9BA1016AB0C for ; Thu, 13 Jul 2017 07:03:30 +0200 (CEST) Received: (qmail 587 invoked by uid 500); 13 Jul 2017 05:03:29 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 568 invoked by uid 99); 13 Jul 2017 05:03:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jul 2017 05:03:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F23041A013A for ; Thu, 13 Jul 2017 05:03:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id GdRiRs02QmPm for ; Thu, 13 Jul 2017 05:03:28 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A400F5F2A9 for ; Thu, 13 Jul 2017 05:03:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6D53Prx022693; Thu, 13 Jul 2017 05:03:26 GMT Message-Id: <201707130503.v6D53Prx022693@ip-10-146-233-104.ec2.internal> Date: Thu, 13 Jul 2017 05:03:25 +0000 From: "Dan Hecht (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5539=3A_Kudu_timestamp_scans_wrong_with_-use_local_tz_for_unix_ts=0A?= X-Gerrit-Change-Id: I423a810427353be76aa64442044133a9a22cdc9b X-Gerrit-ChangeURL: X-Gerrit-Commit: 067c86f1fc4192578ba44be1ab3e5e8f794d3e0a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 13 Jul 2017 05:03:31 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5539: Kudu timestamp scans wrong with -use_local_tz_for_unix_ts ...................................................................... Patch Set 2: (2 comments) This looks fine to me once you add the tests. Let's still do the refactoring/renaming follow on. It's way harder to read the timestamp code than it should be. http://gerrit.cloudera.org:8080/#/c/7311/2/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: PS2, Line 285: the time zone of i think you can delete that part PS2, Line 289: time zone of same -- To view, visit http://gerrit.cloudera.org:8080/7311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I423a810427353be76aa64442044133a9a22cdc9b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes